PMGR-10732 Bumps node version to 16 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worse than that -- they never merged the PR for the tarball-url override which lets us build the nightlies against the RC CLI There is a different syntax I just learned about "two dot diff" vs "three dot diff" -- this is the diff between the two repos: https://github.com/patronmanager/setup-sfdx/compare/master..sfdx-actions:setup-sfdx:master I think we're likely to be forever diverged from the main setup-sfdx repo and that's fine .. |
daveespo
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our fork has diverged a bit from sfdx-actions, however before trying to merge those few changes into our fork I tried changing just the node version and nothing else to see if that was sufficient, and it appears to work fine in my test builds. Do we care about bringing in any other changes besides that? None of them seem particularly functional but rather just just file path changes, and apparently they aren't necessary changes for the thing to work?
master...sfdx-actions:setup-sfdx:master